Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional argument to customize preview comment #44

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

jbusecke
Copy link
Contributor

Thank you so much for these super useful actions.

This PR adds an optional input argument for the preview comment action to enable more customized reuse of the action (outside of the ProjPythia specific context). This should be backwards compatible as far as I can tell.

Thank you so much for these super useful actions. 

This PR adds an optional input argument for the preview comment action to enable more customized reuse of the action (outside of the ProjPythia specific context). 
This should be backwards compatible as far as I can tell.
@brian-rose
Copy link
Member

Hi @jbusecke!

This looks like a useful addition, and agreed should be completely backwards compatible. We haven't yet implemented proper CI tests for this repo (see #6) so it's a bit of a guessing game, but this looks pretty clear so I'll merge it.

@brian-rose
Copy link
Member

I'll merge this, and on the off chance that it breaks something, we'll circle back and fix it.

Thanks for the contribution @jbusecke!

@brian-rose brian-rose merged commit 52c5428 into ProjectPythia:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants